Dear Ben Root, I have made a pull request of matplotlib on github, and I put my venn function on https://github.com/icetime/matplotlib/blob/master/lib/matplotlib/venn.py. However, I'm not sure it is the right place venn.py should go.
This is my first time try to contribute to an open source project. Could someone please help review the code? Any comments will be greatly appreciated.Thanks. Regards, Jianfeng On 2012-2-23 9:22, Benjamin Root wrote: > No need to ask permission. Just make a pull request on github. It may > take some time, but we will get to evaluating your patch. A pull request is > your best bet. > > Ben Root > > On Wednesday, February 22, 2012, Mic wrote: > >> Dear Jianfeng, >> >> Probably, you have to join developer mailing list ( >> http://lists.sourceforge.net/mailman/listinfo/matplotlib-devel ) and ask >> there for permission to submit your code on githup. >> >> Cheers, >> >> >> >> On Tue, Feb 21, 2012 at 10:10 PM, fdu.xia...@gmail.com<javascript:_e({}, >> 'cvml', 'fdu.xia...@gmail.com');> <fdu.xia...@gmail.com<javascript:_e({}, >> 'cvml', 'fdu.xia...@gmail.com');> >>> wrote: >>> Dear Mic, >>> >>> Thanks for your reply. >>> >>> I have never submitted code to matplotlib, and I am not very much >>> familiar with github. However, I guess I don't have the right to submit >>> code to matplotlib. Could you please tell me what I need to do to get my >>> code reviewed by the matplotlib team and perhaps get into matplotlib after >>> the review? I use venn diagram quite often in my daily data analysis, and I >>> think such a function could be useful to others . Thanks a lot. >>> >>> Regards, >>> Jianfeng >>> >>> >>> >>> >>> >>> >>> On 2012-2-18 15:39, Mic wrote: >>> >>>> would be great! Maybe you could submit it to matplotlib's github. >>>> >>>> On Sat, Dec 31, 2011 at 2:23 AM, fdu.xia...@gmail.com<javascript:_e({}, >>>> 'cvml', 'fdu.xia...@gmail.com');> >>>> <fdu.xia...@gmail.com<javascript:_e({}, 'cvml', >>>> 'fdu.xia...@gmail.com');>>wrote: >>>> >> Dear all, >>>>> I couldn't find a function to plot venn diagram with python, so I >>>>> written one for my daily use (with a lot inspirations from the internet >>>>> and R). Hope it could be of any help to someone else, so I put it on >>>>> github. The path to it is >>>>> https://github.com/icetime/**pyinfor/blob/master/venn.py<https://github.com/icetime/pyinfor/blob/master/venn.py>. >>>>> >>>>> I'm wondering if there is any chance that the function be included in >>>>> matplotlib. I think matplotlib need a function for venn diagram. >>>>> >>>>> Also, could someone kindly help to review the code, so I can make it >>>>> better? >>>>> >>>>> Any suggestions or comments will be greatly appreciated. Thanks a lot. >>>>> >>>>> Best Regards, >>>>> Jianfeng >>>>> >>>>> >>>>> >>>>> ------------------------------**------------------------------** >>>>> ------------------ >>>>> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a >>>>> complex >>>>> infrastructure or vast IT resources to deliver seamless, secure access >>>>> to >>>>> virtual desktops. With this all-in-one solution, easily deploy virtual >>>>> desktops for less than the cost of PCs and save 60% on VDI >>>>> infrastructure >>>>> costs. Try it free! >>>>> http://p.sf.net/sfu/Citrix-**VDIinabox<http://p.sf.net/sfu/Citrix-VDIinabox> >>>>> ______________________________**_________________ >>>>> Matplotlib-users mailing list >>>>> Matplotlib-users@lists.**sourceforge.net<javascript:_e({}, 'cvml', >>>>> 'Matplotlib-users@lists.sourceforge.net');> >>>>> https://lists.sourceforge.net/**lists/listinfo/matplotlib-**users<https://lists.sourceforge.net/lists/listinfo/matplotlib-users> >>>> ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Matplotlib-users mailing list Matplotlib-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-users
