[
http://opencast.jira.com/browse/MH-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25199#comment-25199
]
Denis Meyer commented on MH-7053:
---------------------------------
Revision 10123: Replaced the function calls with constants.
> preview-hybrid-initialize.js should use constants
> -------------------------------------------------
>
> Key: MH-7053
> URL: http://opencast.jira.com/browse/MH-7053
> Project: Matterhorn Project
> Issue Type: Sub-Task
> Components: Engage Tools
> Affects Versions: 1.1
> Reporter: Tobias Wunden
> Assignee: Tobias Wunden
> Fix For: 1.1
>
>
> if (event.which === 80 || event.which === 112 || event.which === 83 ||
> event.which === 84 || event.which === 116 || event.which === 115 ||
> event.which === 85 || event.which === 117 || event.which === 68 ||
> event.which === 100 || event.which === 48 || event.which === 49 ||
> event.which === 50 || event.which === 51 || event.which === 52 || event.which
> === 53 || event.which === 54 || event.which === 55 || event.which === 56 ||
> event.which === 57 || event.which === 67 || event.which === 99 || event.which
> === 82 || event.which === 114 || event.which === 70 || event.which === 102 ||
> event.which === 83 || event.which === 115 || event.which === 73 ||
> event.which === 105)
> This should be a switch statement, and should use constants. As a developer
> new to the player, I don't know what event #73 means.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn
To unsubscribe please email
[email protected]
_______________________________________________
