[
http://opencast.jira.com/browse/MH-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25709#comment-25709
]
Christopher Brooks commented on MH-6952:
----------------------------------------
Hi Kenneth, I'm applying the patch right now and will commit another code
review of it. Some comments:
> In the RestService annotation type, there is a key called url. It turns out
> that I have never used this
> because I use a dynamic value obtained in Activator.java (docPath which I
> used in line #115). I think
> using a dynamically obtained value is better than hardcoding that in the
> annotation. I think we are
> remove url from the RestService annotation type. Any comments?
Makes sense to me, but I hope Josh will chime in as he's much more of an expert
in this area than I am.
> Josh had left this comment in a previous code review and I am not sure how I
> should
> do it. http://opencast.jira.com/source/cru/CR-MH-197#c625
Josh; thoughts? A static example wouldn't be ideal, but other than calling the
service I'm not sure how this would be done.
> Also, for the wiki page that I wrote for REST documentation engine, Josh also
> left a comment.
> After searching the codebase, it seems @Consumes is only used by very few
> endpoints. When it is used, it is mostly
I'd like to know that a multipart form is required for using the rest service
(as is the case of ingest). I think @Consumes will tell us that, but it would
be even better if it told us some details about how the form was used.
Not sure I understand the choices question, I couldn't find a corresponding
comment in the cru review. Can you give me a line of code to look at?
>Also, I haven't touched Activator.java in matterhorn-runtime-info-ui yet. I am
>expecting to deal with it
>in MH7358. However, when Josh made that class for me, there is a
>writeTableOfContents() method
I'll leave that for Josh.
> Finally, when I use the auto formatting function in Eclipse, it always
> changes my { } in annotation to {}
> and causes style warning when I build the bundle. So my
> IngestRestService.java has quite a lot of style
> warning because of that. Should our format template be changed to avoid this
> problem?
Can you file this as a bug of low priority and assign to the architecture
group? Someone (likely Tobias?) might be able to rattle this change off,
Chris
> Update the ingest rest endpoint to use these new annotations as an example
> --------------------------------------------------------------------------
>
> Key: MH-6952
> URL: http://opencast.jira.com/browse/MH-6952
> Project: Matterhorn Project
> Issue Type: Sub-Task
> Components: Administrative Tools, Architecture & Services
> Affects Versions: 1.2
> Reporter: Christopher Brooks
> Assignee: Kenneth Lui
> Fix For: 1.2
>
> Attachments: mh6952v1.diff, mh6952v2.diff
>
>
> Kenneth, check out the ingest service endpoints and modify them to use this
> new code. This can serve as a demonstration of what we would like, and would
> give a nice contextualized example of how things should work.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn
To unsubscribe please email
[email protected]
_______________________________________________
