+1 on checkstyles being errors Also, public floggings seem reasonable...
Chris -----Original Message----- From: Josh Holtzman <[email protected]> Sender: [email protected] Date: Fri, 13 May 2011 07:22:34 To: Opencast Matterhorn<[email protected]> Reply-to: Opencast Matterhorn <[email protected]> Subject: Re: [Opencast Matterhorn] Checkstyle and test classes Thanks for doing this Tobias. I also went through the trunk a couple of weeks ago and cleaned up all of the checkstyle violations, only to have things degrage again. Today the trunk is once again producing warnings, less than 24 hours after your cleanup. Since it's now been proven to take less than a day for things to start falling apart, would anyone mind if we change all of checkstyle's warnings to errors? We either care about consistent code style or we don't, and printing warnings in the build logs doesn't enforce anything. Thanks, Josh On May 12, 2011, at 9:35 AM, Tobias Wunden wrote: > Last night's check-in revealed that apparently, our checkstyle configuration > does not take test classes into account. This is why it was possible to > commit a test case that contained an unused import, which could not be > resolved on some people's platform and resulted in a ClassNotFound exception > (the import is part of the sun implementation of the jdk, and hence is not > available on other jdks). > > We have now enabled checkstyle for test classes (and fixed all of the errors > that suddenly appeared), so make sure to comply with the (few) rules that > checkstyle imposes, most notably including a license header in your file. > > Tobias > > > _______________________________________________ > Matterhorn mailing list > [email protected] > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > To unsubscribe please email > [email protected] > _______________________________________________ _______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________ _______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
