[ 
http://opencast.jira.com/browse/MH-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27716#comment-27716
 ] 

David Horwitz commented on MH-8048:
-----------------------------------

Seems I can't attach file, here is a fix assuming the authors intent was to 
trim the strings ...

Index: 
modules/matterhorn-common/src/main/java/org/opencastproject/util/UrlSupport.java
===================================================================
--- 
modules/matterhorn-common/src/main/java/org/opencastproject/util/UrlSupport.java
    (revision 10839)
+++ 
modules/matterhorn-common/src/main/java/org/opencastproject/util/UrlSupport.java
    (working copy)
@@ -129,7 +129,7 @@
       throw new IllegalArgumentException("Argument url is null");
 
     url = checkSeparator(url);
-    url.trim();
+    url = url.trim();
 
     if (url.endsWith("/") || (url.length() == 1))
       return url;
Index: 
modules/matterhorn-common/src/main/java/org/opencastproject/util/PathSupport.java
===================================================================
--- 
modules/matterhorn-common/src/main/java/org/opencastproject/util/PathSupport.java
   (revision 10839)
+++ 
modules/matterhorn-common/src/main/java/org/opencastproject/util/PathSupport.java
   (working copy)
@@ -137,7 +137,7 @@
   public static String trim(String path) {
     if (path == null)
       throw new IllegalArgumentException("Argument path is null");
-    path.trim();
+    path = path.trim();
     path = removeDoubleSeparator(adjustSeparator(path));
     if (path.endsWith(File.separator) || (path.length() == 1))
       return path;


> return value of String.trim() ignored
> -------------------------------------
>
>                 Key: MH-8048
>                 URL: http://opencast.jira.com/browse/MH-8048
>             Project: Matterhorn Project
>          Issue Type: Bug
>          Components: Architecture & Services
>    Affects Versions: 1.3
>            Reporter: David Horwitz
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn


To unsubscribe please email
[email protected]
_______________________________________________

Reply via email to