On 12-03-27 05:27 PM, Tobias Wunden wrote: > Greg, > >> Especially now that we have a QA manager to browbeat developers who are >> recalcitrant in creating, or performing, their reviews. It's not, in my >> opinion, my job nor the RM's job to create reviews for developers. But >> if that's what it takes to start getting code reviews done then I'll do >> it. We're suffering from a lack of polish that's really starting to get >> annoying when man-days are lost while people try and figure out which >> commit broke functionality. > > In my opinion, it could be part of your job as the QA manager *to make sure* > reviews are being conducted. You don't have to do the reviews yourself, nor > do you have to open them, every developer is able to do that. But you could > (and probably should) keep an eye on commits and remind people to open > reviews here and there, as I see code reviews as being the first step to > successful QA.
For sure, and I will definitely be doing that. But each dev should take it upon themselves to create their own reviews so that I'm a check against that, rather than the agent that actually gets the reviews started :) G > Tobias > _______________________________________________ > Matterhorn mailing list > [email protected] > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > To unsubscribe please email > [email protected] > _______________________________________________
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
