Hi Ruben, > As pointed out by Tobias and Christoph, I added a new patch to the trunk. > Please take a look at it (URL reminder: > http://opencast.jira.com/source/cru/CR-MH-490). > > I'm not willing to commit more fixes or dedicate more time to an issue I > didn't cause. If this patch doesn't work, or doesn't meet the standards, > please feel free to commit a new version.
just a quick comment. I can see how you are frustrated by putting a patch in and getting requests to improve it from other people. However, I would like to ask you to try and take this as an opportunity for all of us to get into the habit of doing code reviews, even at the moment you are the one that is "suffering". Lots and lots of code is going into the Matterhorn codebase without any review, and not all of this code is written the way you and I (or anyone else) want it to be written. That's partly due to a lack of knowledge, lack of time and resources etc. and I think it is worth our while to take the time to review, correct, suggest and improve. The reason why I was looking at this patch in particular is because it is located in Ingest, a place that each and every mediapackage passes, so I think we need to make sure there is no room for issues. Thanks! Tobias _______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
