Good day.
During evaluation of a new Maui snapshot, I had noticed that
leading spaces seem to be missed during convertion from snprintf
to MUSNPrintF in MCred.c. The patch is attached.
By the way, what is the status of the snapshot? Is it a real
beta or it can work smoothly? I know that my mileage may vary,
but still...
Thanks!
--
Eygene Ryabinkin, Russian Research Centre "Kurchatov Institute"
>From 0c68cba8e02430ef55ea256d4c50180f62aa7e97 Mon Sep 17 00:00:00 2001
From: Eygene Ryabinkin <[EMAIL PROTECTED]>
Date: Thu, 5 Jun 2008 11:17:46 +0400
Subject: [PATCH] Add missing spaces to MCredShowAttrs().
Seems like initial spaces in the snprintf/MUSNPrintF format were
omitted during conversion from snprintf to MUSNPrintF. Since the
resulting line should have format "attr=value attr=value ...",
spaces were omitted unintentionally.
Signed-off-by: Eygene Ryabinkin <[EMAIL PROTECTED]>
---
src/moab/MCred.c | 70 +++++++++++++++++++++++++++---------------------------
1 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/src/moab/MCred.c b/src/moab/MCred.c
index 1379ff1..dd30a31 100644
--- a/src/moab/MCred.c
+++ b/src/moab/MCred.c
@@ -1799,7 +1799,7 @@ char *MCredShowAttrs(
if (Priority != 0)
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%ld",
+ MUSNPrintF(&BPtr,&BSpace," %s=%ld",
MCredAttr[pindex],
Priority);
}
@@ -1811,7 +1811,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(AP,mptMaxJob,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1823,7 +1823,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(AP,mptMaxNode,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1835,7 +1835,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(AP,mptMaxPE,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1847,7 +1847,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(AP,mptMaxProc,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1859,7 +1859,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(AP,mptMaxPS,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1871,7 +1871,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(AP,mptMaxWC,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1883,7 +1883,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(AP,mptMaxMem,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1895,7 +1895,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(IP,mptMaxJob,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1907,7 +1907,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(IP,mptMaxNode,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1919,7 +1919,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(IP,mptMaxPE,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1931,7 +1931,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(IP,mptMaxProc,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1943,7 +1943,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(IP,mptMaxPS,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1955,7 +1955,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(IP,mptMaxWC,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1967,7 +1967,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(IP,mptMaxMem,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1979,7 +1979,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OAP,mptMaxJob,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -1991,7 +1991,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OAP,mptMaxNode,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2003,7 +2003,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OAP,mptMaxPE,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2015,7 +2015,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OAP,mptMaxProc,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2027,7 +2027,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OAP,mptMaxPS,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2039,7 +2039,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OAP,mptMaxWC,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2051,7 +2051,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OAP,mptMaxMem,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2063,7 +2063,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OIP,mptMaxJob,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2075,7 +2075,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OIP,mptMaxNode,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2087,7 +2087,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OIP,mptMaxPE,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2099,7 +2099,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OIP,mptMaxProc,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2111,7 +2111,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OIP,mptMaxPS,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2123,7 +2123,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OIP,mptMaxWC,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2135,7 +2135,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OIP,mptMaxMem,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2147,7 +2147,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OJP,mptMaxNode,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2159,7 +2159,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OJP,mptMaxPE,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2171,7 +2171,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OJP,mptMaxProc,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2183,7 +2183,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OJP,mptMaxPS,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2195,7 +2195,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OJP,mptMaxWC,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
@@ -2207,7 +2207,7 @@ char *MCredShowAttrs(
if ((Mode & (1 << mcsLimits)) &&
((ptr = __MCredShowLimit(OJP,mptMaxMem,0,ShowUsage)) != NULL))
{
- MUSNPrintF(&BPtr,&BSpace,"%s=%s",
+ MUSNPrintF(&BPtr,&BSpace," %s=%s",
MCredAttr[pindex],
ptr);
}
--
1.5.5.3
_______________________________________________
mauiusers mailing list
[email protected]
http://www.supercluster.org/mailman/listinfo/mauiusers
