On 30-06-10 17:57, Bas van der Vlies wrote:

On 30 jun 2010, at 17:41, Steve Young wrote:

Hi,
        I'm using maui-3.3 and torque-2.4.7. I just noticed that my users are
able to increase/modify their system priority with the setspri
command. I thought that only ADMIN2 users would be allowed to do that?
Would there be something else that allows a user to execute this
command that I should be looking at? Thanks in advance for any advice.

-Steve


Steve,

  I can confirm this  behavior. Just tested it.  We are using maui-3,3. This is 
definitly a bug. The quick work around is to change the permission bits on 
setspri.
Thanks for reporting




I have made a patch that only admin1 and admin1 can update the job priority. The patch is attached. Can this be applied?


--
********************************************************************
*  Bas van der Vlies                    e-mail: [email protected]       *
*  SARA - Academic Computing Services   Amsterdam, The Netherlands *
********************************************************************
Index: src/server/UserI.c
===================================================================
--- src/server/UserI.c	(revision 1)
+++ src/server/UserI.c	(working copy)
@@ -5535,9 +5535,14 @@
 
       {
       long tmpPrio;
+      tmpPrio = strtol(Val,NULL,0); 
+      
+      if (!(CFlags & ((1 << fAdmin1) | (1 << fAdmin2))))
+        {
+	sprintf(Msg,"ERROR:  not authorized to run this command");
+        return(FAILURE);
+        }
 
-      tmpPrio = strtol(Val,NULL,0);
-
       if ((tmpPrio < 0) || (tmpPrio > 1000))
         {
         strcpy(Msg,"ERROR:  system priority must be in the range 0 - 1000");
_______________________________________________
mauiusers mailing list
[email protected]
http://www.supercluster.org/mailman/listinfo/mauiusers

Reply via email to