Fixed: https://github.com/mayan-edms/mayan-edms/commit/0d3ce55f390a7c390a946b5d78c334ec590fdcc1
Previously the EmailAuthenticationForm form inherited from Django's AuthenticationForm, which is inherently made to work only with username/password login combination and was more or less being monkey-patched (https://en.wikipedia.org/wiki/Monkey_patch) (https://stackoverflow.com/questions/5626193/what-is-monkey-patch) for email/password login. At the end this approach fell victim to this: *"They can lead to upgrade problems when the patch makes assumptions about > the patched object that are no longer true; if the product you have changed > changes with a new release it may very well break your patch."* On Sunday, July 27, 2014 5:26:18 PM UTC-4, Devin Ceartas wrote: > > Thanks. I have started looking at the pages about the User model change > you pointed out in the other thread. > > It is confusing to me -- if Django made this change, why are other parts > of Django not updated to be consistent? I think the file I patched was > under the "/contrib/" directory, so maybe it's not core Django? Is there > any hope of tracking down the correct place for the patch and submitting it > there, or will I just need to maintain a private patch set? If there is a > patch set for things Mayan suggests are possible, we may need a place to > collect those? > > Or are you suggesting we can somehow side-step this issue by changing > something about Mayan? It looked to me like all the authentication was > pretty much handled outside of the Mayan code? > > devin > -- > contact info: http://nacredata.com/devin > gpg public key: http://www.nacredata.com/public_key.txt > Use unique, strong passwords! https://www.nacredata.com/password.php > > > > > > > > > On Jul 27, 2014, at 9:11 PM, Roberto Rosario <roberto.rosa.....> wrote: > > My guess is that this is related to the User model updates (Mayan went > from Django 1.3 to Django 1.6) so hopefully a quick update in how Mayan > does the authentication will fix it. > > The patch included goes directly against Django so that is something that > cannot be included in Mayan itself. > > -- > > --- > You received this message because you are subscribed to a topic in the > Google Groups "Mayan EDMS" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/mayan-edms/q1sh1IVzmuw/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. > > > -- --- You received this message because you are subscribed to the Google Groups "Mayan EDMS" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
