Re: svn commit: r160602 [1/3] - in httpd/mod_mbox/trunk: ./ config/ m4/ module-2.0/

[Paul Querna]

Justin Erenkrantz wrote:

@@ -94,14 +103,14 @@

    temp = r->filename;
    r->filename = absfile;
-    rv = generate_index(r, f);
+    rv = mbox_generate_index(r, f, indexer, list, domain);
    r->filename = temp;

    if (rv != APR_SUCCESS) {
        apr_file_printf(errfile, "Error: Index Generation for '%s' failed: %s" 
NL,
                        absfile,
                        apr_strerror(rv, errbuf, sizeof(errbuf)));
-        return EXIT_FAILURE;
+        return 0;
    }

Um.  Are you sure changing the exit code is right?  (It's likely not.)

Yes, I am sure.  mod-mbox-util is ran on an entire directory of .mbox
files, process_mbox() returns non-zero if it was a truly fatal error --
 this allows generate_index to continue and process the rest of the
directory.

I decide that stopping the processing of the rest of the directory,
because of a problem with one .mbox file was likely not the desired
behavior.

Also, whatever editor you are using for your commits is adding tons of
whitepsace on blank lines and adds loads of trailing whitespace.  Can you
please fix up your editor to not do that any more?

Hmm. Odd. Normally XCode is pretty good.  Ill try to tweak it to be nicer.