On Wed, 9 Jul 2003, it was written: > When moving >1 files every file is accounted twice in "count" progress bar. > Each file is copied with copy_file_file() (which does accounting) and > then removed. > Following patch fixes this (don't know if this has any side effects). > Consider applying. Patch is against current CVS.
Test 1. Moving one large directory. There is no "count" bar at all. Obviously a bug. Test 2. Moving three large directories. The "count" bar stays at 0. Obviously another bug. Test 3. Moving three large files. Yes, that's where your patch helps. Test 4. Moving 9 symlinks and 3 large files. The count ends at 25%. Obviously one more bug. Test 5. Copying 9 symlinks and 3 large files. The count ends at 25%. The last bug is in the copy routine. Your patch eliminates counting symlinks, and the copy routine doesn't count them either. Not good. I believe that your patch does something wrong when symlinks are involved, but I cannot say it for sure before copying is fixed. With so many bugs around, I think it's better to fix the most basic of them rather than compensate for bugs and introduce new ones. I'll try to clean up what I can. -- Regards, Pavel Roskin _______________________________________________ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
