Hello Leonard, mc-devel, On Mon, 2005-06-06 at 23:34 +0200, Leonard den Ottolander wrote: > Hello Miguel, > > On Mon, 2005-06-06 at 22:58, Miguel de Icaza wrote: > > I have made a tarball of the current "trunk" release and fixing a > > few issues in make distcheck, the question that remains is: what version > > should we use? > > Please use MC_4_6_1_PRE for the release of 4.6.1. Then we can use HEAD > for 4.6.2 and onwards. > > All we need for PRE is possibly the fixes that proski introduced for > gcc-4 warnings and some translations. That should suffice for 4.6.1. I > would say you can call that code very stable.
I can confirm that all the "signedness" gcc4 warnings are now gone in the current CVS. The only warnings I found were not gcc4 related with trivial fix, but it would be nice to see it fixed in the next mc release. I discussed this with Roland so maybe it's fixed now already. Attaching the patch anyway. Cheers, Jindrich -- Jindrich Novy <[EMAIL PROTECTED]>, http://people.redhat.com/jnovy/ The worst evil in the world is refusal to think.
--- mc-4.6.1a/src/widget.c.fixes 2005-06-06 15:08:52.202559824 +0200 +++ mc-4.6.1a/src/widget.c 2005-06-06 15:08:29.120068896 +0200 @@ -2363,7 +2363,7 @@ buttonbar_set_label_data (Dlg_head *h, i void buttonbar_set_label (Dlg_head *h, int idx, const char *text, void (*cback) (void)) { - buttonbar_set_label_data (h, idx, text, cback, 0); + buttonbar_set_label_data (h, idx, text, (buttonbarfn)cback, 0); } void --- mc-4.6.1a/src/command.c.fixes 2005-05-27 05:35:15.000000000 +0200 +++ mc-4.6.1a/src/command.c 2005-06-06 15:07:38.228805544 +0200 @@ -280,7 +280,7 @@ command_callback (Widget *w, widget_msg_ /* fall through */ default: - return input_callback (cmd, msg, parm); + return input_callback (w, msg, parm); } }
_______________________________________________ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel