this is cool, and i think the format is fine. it should make it a bit easier to find stack frames. (well, easier and prettier than .,40/naPP) ed
On Fri, Feb 13, 2009 at 01:37:12AM +0000, John Levon wrote: > On Thu, Feb 12, 2009 at 05:26:31PM -0800, Jonathan Adams wrote: > > > > > <rsp,0x60::dump -S > > > 7ffffec0fb28: 00007ffffe2c6c56 00007ffffe32f3f8 > > > 7ffffec0fb28: libvirt.so.0.6.0`virEnumFromString+0x36 > > > 7ffffec0fb38: 00000000004ca9f0 0000000000000000 > > > 7ffffec0fb48: 00000000004cb948 00007ffffec0fb60 > > > 7ffffec0fb58: 00007ffffe2d3a2b 00007ffffec0fc00 > > > 7ffffec0fb58: libvirt.so.0.6.0`virDomainGraphicsTypeFromString+0x1b > > > > > > It's a trivial patch - do people think it's worth it, and any > > > preferences over the format? > > > > So does this just indent lines which correspond to symbols? > > It's printing a separate indented line for every sym found at each group in > the > line above (i.e. it's additional). Clearer in these examples: > > > <rsp,0x60::dump -S -w 4 > 7ffffec0fb28: 00007ffffe2c6c56 00007ffffe32f3f8 00000000004ca9f0 > 0000000000000000 00000000004cb948 00007ffffec0fb60 00007ffffe2d3a2b > 00007ffffec0fc00 > 7ffffec0fb28: libvirt.so.0.6.0`virEnumFromString+0x36 > 7ffffec0fb58: libvirt.so.0.6.0`virDomainGraphicsTypeFromString+0x1b > 7ffffec0fb68: 00007ffffe305e34 00007ffffe332c30 00007ffffe332c18 > 00007ffffe332c00 00007ffffe332be8 00007ffffe332bd0 00000000004d0790 > 00007ffffe332bb8 > 7ffffec0fb68: libvirt.so.0.6.0`xenDaemonParseSxprGraphicsNew+0xf4 > > <rsp,0x60::dump -S -w 4 -r > 00: 00007ffffe2c6c56 00007ffffe32f3f8 00000000004ca9f0 0000000000000000 > 00000000004cb948 00007ffffec0fb60 00007ffffe2d3a2b 00007ffffec0fc00 > 0+0: libvirt.so.0.6.0`virEnumFromString+0x36 > 0+30: libvirt.so.0.6.0`virDomainGraphicsTypeFromString+0x1b > 40: 00007ffffe305e34 00007ffffe332c30 00007ffffe332c18 00007ffffe332c00 > 00007ffffe332be8 00007ffffe332bd0 00000000004d0790 00007ffffe332bb8 > 40+0: libvirt.so.0.6.0`xenDaemonParseSxprGraphicsNew+0xf4 > > regards > john > _______________________________________________ > mdb-discuss mailing list > mdb-discuss at opensolaris.org