Santhosh has submitted this change and it was merged. Change subject: Fix issues found by JSHint ......................................................................
Fix issues found by JSHint * Add "use strict". * Remove a redundant comma. * Define typeChars() explicitly. Also added comments to lines with ZWNJ. JSHint complains that it's an "unsafe character". This doesn't remove the warning, but it makes the context clearer, because otherwise the character is invisible. Change-Id: I9caa348b694dab2b3606b4f1d4bb3da6522f5d44 --- M tests/qunit/ext.narayam.rules.tests.js 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Santhosh: Verified; Looks good to me, approved Nikerabbit: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/14772 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9caa348b694dab2b3606b4f1d4bb3da6522f5d44 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Narayam Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Logicwiki <srik....@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits