Reedy has submitted this change and it was merged. Change subject: ChannelFeed now marked as an abstract class ......................................................................
ChannelFeed now marked as an abstract class The ChannelFeed class has always been considered as an abstract class. Looks like we forgot to update its definition since PHP switched to support class abstractions. Also marked abstract the three inner methods that must be extended: ChannelFeed::outHeader() ChannelFeed::outItem() ChannelFeed::outFooter() Change-Id: Ie0111786af37531d53ee3fc845e0125136ca298f --- M includes/Feed.php 1 file changed, 17 insertions(+), 11 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/14877 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0111786af37531d53ee3fc845e0125136ca298f Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
