Catrope has submitted this change and it was merged. Change subject: Avoid mangling fields in API continuation parameters ......................................................................
Avoid mangling fields in API continuation parameters API continuation parameters encode sufficient state for a subsequent query to continue where the previous one left off; this may sometimes include page titles, with or without the namespace. Given that these page titles are already in the exact format required for the next request's SQL query, it is not necessary to "normalize" them in any way. And if normalization does more than just change spaces to underscores or vice versa (e.g. it canonicalizes namespace aliases or capitalizes the first letter of the title), it can be actively harmful: see bug 36987 and bug 29290. Note this patch involves a breaking API change: the values for the "continue" parameter of various modules have been changed, and some modules will now return "continue" as the continuation parameter instead of reusing "from". Note this patch also corrects a minor logic bug in ApiQueryAllLinks, changing ">" to ">=". The line is being changed anyway, so I didn't bother doing a separate changeset. Change-Id: I459232e919d20f89f6de9d20640fd48c8fd5781c --- M RELEASE-NOTES-1.20 M includes/api/ApiQueryAllCategories.php M includes/api/ApiQueryAllImages.php M includes/api/ApiQueryAllLinks.php M includes/api/ApiQueryAllPages.php M includes/api/ApiQueryCategories.php M includes/api/ApiQueryDeletedrevs.php M includes/api/ApiQueryDuplicateFiles.php M includes/api/ApiQueryFilearchive.php M includes/api/ApiQueryIWBacklinks.php M includes/api/ApiQueryIWLinks.php M includes/api/ApiQueryImages.php M includes/api/ApiQueryLangBacklinks.php M includes/api/ApiQueryLinks.php M includes/api/ApiQueryWatchlistRaw.php 15 files changed, 121 insertions(+), 67 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/8407 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I459232e919d20f89f6de9d20640fd48c8fd5781c Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
