Tim Starling has submitted this change and it was merged. Change subject: [FileBackend] MultiWrite code improvements and sanity checks. ......................................................................
[FileBackend] MultiWrite code improvements and sanity checks. * Automatically override a few sub-backend settings in FileBackendMultiWrite. We should ignore locking, journaling, or read-only settings of sub-backends. Journaling is now done just for master sub-backend paths (under the proxy backend name). We don't need to log for each sub-backend, which is a waste of disk space. * Changed FileBackendMultiWrite::doOperationsInternal() to be similiar to the other write functions. It now uses doOperations() of the sub-backends rather than manual code. This makes settings like 'concurrency' easier to manage; we might want to have some sub-backends with varying setings for that. * Made FileBackendMultiWrite::doQuickOperationsInternal() compliant with docs. * Added CHECK_SHA1 option for consistency checking. * Fixed function visibility in two places. * Improved multiwrite backend tests by calling consistencyCheck(). Change-Id: Iac7bfe10c77ecd069fb9ef0ec26a01512f5f4eea --- M includes/filerepo/backend/FileBackend.php M includes/filerepo/backend/FileBackendMultiWrite.php M includes/filerepo/backend/FileBackendStore.php M tests/phpunit/includes/filerepo/FileBackendTest.php 4 files changed, 91 insertions(+), 66 deletions(-) Approvals: Tim Starling: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/7980 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac7bfe10c77ecd069fb9ef0ec26a01512f5f4eea Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Mglaser <[email protected]> Gerrit-Reviewer: Tim Starling <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
