Krinkle has submitted this change and it was merged. Change subject: JSHint: Added dotfiles and fixed tons of linting warnings. ......................................................................
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de --- A .jshintignore A .jshintrc M modules/ve/ce/nodes/ve.ce.ImageNode.js M modules/ve/ce/nodes/ve.ce.TextNode.js M modules/ve/ce/ve.ce.BranchNode.js M modules/ve/ce/ve.ce.Surface.js M modules/ve/dm/nodes/ve.dm.DefinitionListItemNode.js M modules/ve/dm/nodes/ve.dm.HeadingNode.js M modules/ve/dm/nodes/ve.dm.ListNode.js M modules/ve/dm/nodes/ve.dm.TableCellNode.js M modules/ve/dm/nodes/ve.dm.TableSectionNode.js M modules/ve/dm/ve.dm.Converter.js M modules/ve/dm/ve.dm.Document.js M modules/ve/dm/ve.dm.Node.js M modules/ve/dm/ve.dm.Surface.js M modules/ve/dm/ve.dm.Transaction.js M modules/ve/dm/ve.dm.TransactionProcessor.js M modules/ve/init/targets/ve.init.ViewPageTarget.js M modules/ve/init/ve.init.Target.js M modules/ve/ui/inspectors/ve.ui.LinkInspector.js M modules/ve/ui/tools/ve.ui.FormatDropdownTool.js M modules/ve/ui/tools/ve.ui.IndentationButtonTool.js M modules/ve/ui/ve.ui.Context.js M modules/ve/ui/ve.ui.Toolbar.js M modules/ve/ui/ve.ui.js M modules/ve/ve.BranchNode.js M modules/ve/ve.Document.js M modules/ve/ve.Surface.js M modules/ve/ve.js M tests/ve/ce/nodes/ve.ce.TextNode.test.js M tests/ve/dm/ve.dm.Surface.test.js M tests/ve/ve.BranchNode.test.js M tests/ve/ve.example.js 33 files changed, 429 insertions(+), 299 deletions(-) Approvals: Krinkle: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16003 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
