Catrope has submitted this change and it was merged. Change subject: Bug 33163 - VisualEditor: Floating toolbar should not be displayed when the edit area is entirely off-screen ......................................................................
Bug 33163 - VisualEditor: Floating toolbar should not be displayed when the edit area is entirely off-screen - Added limits to toolbar float, Toolbar will not go past the last node in editor. - Added bottom mode to allow toolbar to stick above the last node until the scroll position is above the last node. - Actually checking toolbar config now and setting float when flag is set. - Gave float method for top toolbar a better name. Change-Id: Ic39c5402fa7a05e13c5e81722d8729d93776d7e9 --- M modules/ve/ui/styles/ve.ui.Surface.css M modules/ve/ve.Surface.js 2 files changed, 54 insertions(+), 11 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/14072 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic39c5402fa7a05e13c5e81722d8729d93776d7e9 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Robmoen <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Robmoen <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
