Aaron Schulz has submitted this change and it was merged. Change subject: Use User::getDefaultOption() instead of $wgDefaultUserOptions ......................................................................
Use User::getDefaultOption() instead of $wgDefaultUserOptions Using User::getDefaultOption() in User::setOption() sets preferences like 'language' to the right default value, whereas using $wgDefaultOptions sets the language to null because language is not part of $wgDefaultUserOptions, but it is part of return value of User::getDefaultOption(). This only makes problems when reusing the same user object, because when a new user object is created, the value of 'language' is correct. Change-Id: I43a32c66fc3997a4f842c63af374e84d234602b2 --- M includes/User.php 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/9724 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43a32c66fc3997a4f842c63af374e84d234602b2 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Liangent <[email protected]> Gerrit-Reviewer: Umherirrender <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
