Hashar has submitted this change and it was merged.
Change subject: Add tests for EtherEditorPad, and make them work.
......................................................................
Add tests for EtherEditorPad, and make them work.
This is a further addition of phpunit tests, so now the entire
codebase should be covered. And indeed, I have the code coverage
files that prove it.
Well, the last remaining things to test would be the remainder of
the frontend and the actual hooks themselves. I don't currently
intend to do that, though, so it looks like I'm done with unit
testing for now!
Patchset 2: Make most of hashar's changes, at least some of which
were incorporated in the commit we depend on.
Conflicts:
EtherEditorHooks.php (one include addition)
Change-Id: I8cc6465c73010c32b80f18c4ae0350c233620f2e
---
M EtherEditorHooks.php
M api/DeleteEtherPad.php
M api/EtherPadAuth.php
M api/ForkEtherPad.php
M api/GetContribs.php
M api/GetEtherPadText.php
M api/KickFromPad.php
M includes/EtherEditorPad.php
M includes/EtherpadLiteClient.php
M tests/phpunit/Makefile
A tests/phpunit/includes/EtherEditorPadTest.php
11 files changed, 123 insertions(+), 16 deletions(-)
Approvals:
Hashar: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/14401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cc6465c73010c32b80f18c4ae0350c233620f2e
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/EtherEditor
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
