Reedy has uploaded a new change for review.

Change subject: Don't use explode after IN to build sql queries. The SQL 
wrappers will do this for you (in if array, = if single)
......................................................................

Don't use explode after IN to build sql queries. The SQL wrappers will do this 
for you (in if array, = if single)

Don't manually quote values either (ie "bot"), again, the SQL wrappers will do 
this for you.

Don't re-invent the wheel!!

Change-Id: I6367d4de69da6c3ef429fe71034e1e49e14b07fe
---
M ArticleFeedbackv5.fetch.php
M ArticleFeedbackv5.hooks.php
2 files changed, 28 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 
refs/changes/44/16944/1
--
To view, visit https://gerrit.wikimedia.org/r/16944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6367d4de69da6c3ef429fe71034e1e49e14b07fe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to