Reedy has submitted this change and it was merged. Change subject: Fix inherited doBatchLookups method to use global user name. ......................................................................
Fix inherited doBatchLookups method to use global user name. I have copied doBatchLookups method from UsersPager class and changed the name of field from user_name to gu_name. I don't like code duplication so maybe better solution is to create an alias user_name of gu_name in the sql query? Change-Id: Ibc79a9b5e49b4138e17103674f986454e22c2291 --- M specials/SpecialGlobalUsers.php 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved awjrichards: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/6911 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc79a9b5e49b4138e17103674f986454e22c2291 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralAuth Gerrit-Branch: master Gerrit-Owner: Szymon Świerkosz <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: Victor Vasiliev <[email protected]> Gerrit-Reviewer: awjrichards <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
