Jens Ohlig has submitted this change and it was merged. Change subject: Refactor Wikibase API tests. ......................................................................
Refactor Wikibase API tests. Created common setup of well known test items which caqn be reused by all test classes. Changed tests to use it. NOTE: the new tests actually uncovered two bugs in ApiSetSiteLink. ApiSetSiteLinkTest will report two failed assertions until these are fixed. patchset 2: some fixes. patchset 3: deleted obsolete/inactive stuff patchset 4: reset item to avoid bad state patchset 5: a few minor spelling and style fixes Change-Id: I2a49c7ea7ea14ffda73bbdfd2d067b407f4dc161 --- M repo/Wikibase.hooks.php A repo/tests/phpunit/includes/api/ApiGetItemsTest.php M repo/tests/phpunit/includes/api/ApiLanguageAttributeTest.php M repo/tests/phpunit/includes/api/ApiModifyItemBase.php M repo/tests/phpunit/includes/api/ApiPermissionsTest.php M repo/tests/phpunit/includes/api/ApiSetAliasesTest.php M repo/tests/phpunit/includes/api/ApiSetItemTest.php M repo/tests/phpunit/includes/api/ApiSetSiteLinkTest.php 8 files changed, 1,283 insertions(+), 1,136 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/17332 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a49c7ea7ea14ffda73bbdfd2d067b407f4dc161 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Jens Ohlig <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
