MarkTraceur has uploaded a new change for review.

Change subject: (bug 38514) Parse the pipe-trick (most renditions) properly
......................................................................

(bug 38514) Parse the pipe-trick (most renditions) properly

There is still one form of "pipe trick" missing from this patch,
but the usual forms are both working:

* [[page (context)|]] -> [[page (context)|page]]
* [[page, context|]] -> [[page, context|page]]

The functionality was copied almost verbatim from Parser.php.

The only remaining form to implement is:

[[|page]] -> [[page|page]]

I feel like there needs to be a chat about that, since A) it would
need some changes in the tokenizer (recognizing links without URLs
is one), but also it seems like this is just a long form of the
standard [[page]] (which, ha, is also broken), so we may want to
not implement the longer form.

Change-Id: I62dbee54c03f9e26ed830ba77eb4b6ab999a6371
---
M js/lib/ext.core.LinkHandler.js
M js/lib/pegTokenizer.pegjs.txt
2 files changed, 33 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/96/17896/1
--
To view, visit https://gerrit.wikimedia.org/r/17896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62dbee54c03f9e26ed830ba77eb4b6ab999a6371
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to