Catrope has submitted this change and it was merged. Change subject: Kranitor #2: Pass JSHint on resources/mediawiki/* ......................................................................
Kranitor #2: Pass JSHint on resources/mediawiki/* * .jshintrc - Update properties to reflect our conventions more * Re-pass resources/jquery/* * Pass resources/mediawiki/* - Trailing whitespace - Whitelist the one usage of document.write with a local /*jshint evil:true */ in the function that we allow to use it. - Get rid of dangling _ in var names and undescriptive instances of '_this'. - More code conventions * Add a few documentation comments while at it Change-Id: Ic4f2b5d473a440667a40e4d5f12f40877386b02f --- M .jshintrc M resources/jquery/jquery.makeCollapsible.js M resources/jquery/jquery.textSelection.js M resources/mediawiki.action/mediawiki.action.edit.js M resources/mediawiki.action/mediawiki.action.history.js M resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js M resources/mediawiki.action/mediawiki.action.view.metadata.js M resources/mediawiki.language/mediawiki.language.init.js M resources/mediawiki.language/mediawiki.language.js M resources/mediawiki.page/mediawiki.page.startup.js M resources/mediawiki.page/mediawiki.page.watch.ajax.js M resources/mediawiki.special/mediawiki.special.changeemail.js M resources/mediawiki.special/mediawiki.special.javaScriptTest.js M resources/mediawiki.special/mediawiki.special.recentchanges.js M resources/mediawiki.special/mediawiki.special.upload.js M resources/mediawiki/mediawiki.Title.js M resources/mediawiki/mediawiki.Uri.js M resources/mediawiki/mediawiki.debug.js M resources/mediawiki/mediawiki.feedback.js M resources/mediawiki/mediawiki.htmlform.js M resources/mediawiki/mediawiki.jqueryMsg.js M resources/mediawiki/mediawiki.js M resources/mediawiki/mediawiki.log.js M resources/mediawiki/mediawiki.user.js M resources/mediawiki/mediawiki.util.js 25 files changed, 756 insertions(+), 751 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16718 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4f2b5d473a440667a40e4d5f12f40877386b02f Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
