Markus Kroetzsch has submitted this change and it was merged. Change subject: removing the Factory class for DIHandlers ......................................................................
removing the Factory class for DIHandlers This commit removes the factory class for DIHandlers instead the handlers are created by the store3 and cached as well to ensure efficiency. However, some places the Store3 itself is created newly and this leads to inefficiency but this has to be fixed in a separate commit. Patchset3: Modified as per comments, the store object is no more created anywhere on demand and is passed Patchset4: Type hinting and direct access Change-Id: Ibf0bb1ff1e27362a58634f45a74f2de609e053aa --- M includes/SMW_Setup.php M includes/storage/SQLStore/SMW_DIHandler_Blob.php M includes/storage/SQLStore/SMW_DIHandler_Bool.php M includes/storage/SQLStore/SMW_DIHandler_Concept.php M includes/storage/SQLStore/SMW_DIHandler_Container.php M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php M includes/storage/SQLStore/SMW_DIHandler_Number.php M includes/storage/SQLStore/SMW_DIHandler_Property.php M includes/storage/SQLStore/SMW_DIHandler_String.php M includes/storage/SQLStore/SMW_DIHandler_Time.php M includes/storage/SQLStore/SMW_DIHandler_URI.php M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php M includes/storage/SQLStore/SMW_DataItemHandler.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3Table.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3StubSemanticData.php 20 files changed, 139 insertions(+), 96 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/19389 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0bb1ff1e27362a58634f45a74f2de609e053aa Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Nischayn22 <nischay...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
