Catrope has submitted this change and it was merged. Change subject: VE multiSuggest bug fixes. ......................................................................
VE multiSuggest bug fixes. -Using keydown on arrows allows preventDefault which stops the cursor movement in the input. -Consolidated Keydown bindings, no longer unbinding keydown, instead checking for visible state first. -Using case insensitive comparison for selected item. -Changed use of ve.inArray to ve.indexOf because method name was changed. -Moved clear break into suggestion container rather than after it. Added margin bottom on suggestion container for category separation. Change-Id: I2bd1db049a948db189194037dc8e38dfe884c197 --- M modules/jquery/jquery.multiSuggest.js M modules/ve/ui/inspectors/ve.ui.LinkInspector.js M modules/ve/ui/styles/ve.ui.Inspector.css 3 files changed, 27 insertions(+), 30 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/20497 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bd1db049a948db189194037dc8e38dfe884c197 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Robmoen <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
