Siebrand has uploaded a new change for review. Change subject: Maintenance for PageTriage extension. ......................................................................
Maintenance for PageTriage extension. * Remove unused globals. * Use context where possible instead of globals. * Remove unused local variables. * Return void instead of true if that's the return type (ApiPageTriageTemplate::execute()). * Sprinkle semi-colons over JavaScript, take a few from existing code, too. * Return immediately instead of using a local variable assignment where possible. * Simplify if/then/else/return into return. * Update doc and add missing return value for WikiApi::getPage(). Change-Id: Ibc0a7181e07839c89c2963a6c1de64fc4e1647b3 --- M PageTriage.hooks.php M SpecialNewPagesFeed.php M api/ApiPageTriageTemplate.php M includes/PageTriageUtil.php M modules/ext.pageTriage.article/ext.pageTriage.article.js M modules/ext.pageTriage.models/ext.pageTriage.article.js M modules/ext.pageTriage.models/ext.pageTriage.revision.js M modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js M modules/ext.pageTriage.views.toolbar/ext.pageTriage.toolbarView.js M modules/ext.pageTriage.views.toolbar/ext.pageTriage.wikilove.js M tests/phpunit/ApiPageTriageActionTest.php M tests/phpunit/SpecialPageTriageTest.php M tools/importNewPages.php 13 files changed, 43 insertions(+), 46 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage refs/changes/80/21480/1 -- To view, visit https://gerrit.wikimedia.org/r/21480 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc0a7181e07839c89c2963a6c1de64fc4e1647b3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
