Yaron Koren has submitted this change and it was merged. Change subject: Maintenance for SemanticForms extension. ......................................................................
Maintenance for SemanticForms extension. * Replace deprecated wfMsg* with wfMessage (1.17 compat). Fixed some unescaped output, but probably didn't catch them all. Code should probably be audited for this. * Remove some superfluous newlines. * Added FIXMEs for i18n issues. * Rename parameter $s to $pageTitle for clarity. * Remove unused local variables and unused globals. * Fixed incorrect indentation. * Remove unneeded returns in JavaScript. * Removed redundant units of measurement in CSS. Change-Id: I9c22fcf45167cd824777ec3e461784ff79b5ff47 --- M includes/SF_AutoeditAPI.php M includes/SF_Form.php M includes/SF_FormEditAction.php M includes/SF_FormEditPage.php M includes/SF_FormField.php M includes/SF_FormLinker.php M includes/SF_FormPrinter.php M includes/SF_FormUtils.php M includes/SF_HelperFormAction.php M includes/SF_PageSchemas.php M includes/SF_ParserFunctions.php M includes/SF_TemplateField.php M includes/SF_TemplateInForm.php M includes/SF_Utils.php M includes/forminputs/SF_CategoriesInput.php M includes/forminputs/SF_CategoryInput.php M includes/forminputs/SF_CheckboxInput.php M includes/forminputs/SF_ComboBoxInput.php M includes/forminputs/SF_DateTimeInput.php M includes/forminputs/SF_EnumInput.php M includes/forminputs/SF_FormInput.php M includes/forminputs/SF_ListBoxInput.php M includes/forminputs/SF_MultiEnumInput.php M includes/forminputs/SF_RadioButtonInput.php M includes/forminputs/SF_TextAreaInput.php M includes/forminputs/SF_TextAreaWithAutocompleteInput.php M includes/forminputs/SF_TextInput.php M includes/forminputs/SF_TextWithAutocompleteInput.php M includes/forminputs/SF_YearInput.php M libs/jquery.fancybox.js M skins/SF_popupform.css M skins/SemanticForms.css M skins/jquery.fancybox.css M specials/SF_CreateCategory.php M specials/SF_CreateClass.php M specials/SF_CreateForm.php M specials/SF_CreateProperty.php M specials/SF_CreateTemplate.php M specials/SF_FormEdit.php M specials/SF_FormStart.php M specials/SF_Forms.php M specials/SF_RunQuery.php M specials/SF_Templates.php M specials/SF_UploadWindow.php 44 files changed, 344 insertions(+), 363 deletions(-) Approvals: Yaron Koren: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/21538 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c22fcf45167cd824777ec3e461784ff79b5ff47 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticForms Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Yaron Koren <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
