Tim Starling has submitted this change and it was merged. Change subject: Don't run Preprocessor::preprocessToObj() on cache hits ......................................................................
Don't run Preprocessor::preprocessToObj() on cache hits Don't run Preprocessor::preprocessToObj() for frame:preprocess() on cache hits, only do it on cache misses. The rationale for passing a PPNode from expandTemplate() to doCachedExpansion() remains: Parser implements its own cache, as well as extra logic, inside getTemplateDom(). Change-Id: I29e85e3e98d9590bbd1ae49fb2bb4deaa895edc9 --- M engines/LuaCommon/LuaCommon.php 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Tim Starling: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/21544 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29e85e3e98d9590bbd1ae49fb2bb4deaa895edc9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Scribunto Gerrit-Branch: master Gerrit-Owner: Tim Starling <[email protected]> Gerrit-Reviewer: Tim Starling <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
