Aaron Schulz has submitted this change and it was merged. Change subject: Moved warning stuff into MWDebug class. ......................................................................
Moved warning stuff into MWDebug class. - Group common code in one instead of doing checks one time in GlobalFunctions.php and another time in Debug.php - Remove the code catching the fact that a warning is due to a deprecation warning, no longer needed - Pass the caller offset from wfDeprecated() to MWDebug::deprecated(); this was breaking deprecation notices for global objects. - Changed PHP error level for deprecation notices (when $wgDevelopmentWarnings is set to true) from E_USER_NOTICE to E_USER_DEPRECATED since we now require PHP 5.3+ - Added E_USER_DEPRECATED to wfSuppressWarnings() and removed the check for the E_DEPRECATED constant being set now that we require PHP 5.3+ - Fixed MWDebugTest by calling wfSuppressWarnings() and wfRestoreWarnings() in setUp() and tearDown() Change-Id: I6810b57c90d384de55a2cf177047767cdb734f79 --- M includes/GlobalFunctions.php M includes/debug/Debug.php M tests/phpunit/includes/debug/MWDebugTest.php 3 files changed, 141 insertions(+), 109 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/21408 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6810b57c90d384de55a2cf177047767cdb734f79 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Eranroz <[email protected]> Gerrit-Reviewer: IAlex <[email protected]> Gerrit-Reviewer: SPQRobin <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
