Dzahn has uploaded a new change for review. Change subject: do not quote booleans or they become strings, the string "false" can actually be true. ......................................................................
do not quote booleans or they become strings, the string "false" can actually be true. http://docs.puppetlabs.com/puppet/2.7/reference/lang_datatypes.html#booleans also, pass the $enabled variable to the unixaccount definition. note how some accounts have "if $enabled == true and $manage_home", even though i would like consistency i did not add that to all, since that would mean when enabled is false it would also never get to the "ensure => absent" of the SSH key. further, how about adding $enabled = true to all accounts even though it is the default to make sure people don't forget to change that to false as well when disabling accounts Change-Id: If13b6bb4ae9898c1fcbf95a09ae2f8e70d4fd40f --- M manifests/admins.pp 1 file changed, 112 insertions(+), 112 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/59/21759/1 -- To view, visit https://gerrit.wikimedia.org/r/21759 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If13b6bb4ae9898c1fcbf95a09ae2f8e70d4fd40f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
