Krinkle has submitted this change and it was merged. Change subject: Work around preg_replace_callback() issue in CSSJanus ......................................................................
Work around preg_replace_callback() issue in CSSJanus As reported in bug 38294, CSSJanus returns an empty string for some input. This seems to be caused by preg_replace_callback() returning null which, according to the PHP docs, happens "in case of error". Of course there's no way to figure out what the error was :S Work around this by checking for a null return value Change-Id: I5db952bc32f73b94ac13e449d9aa1f8693602dbd --- M includes/libs/CSSJanus.php 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Krinkle: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/21775 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5db952bc32f73b94ac13e449d9aa1f8693602dbd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Catrope <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Amire80 <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
