Matthias Mullie has submitted this change and it was merged. Change subject: Fix flyover positioning for RTL environments ......................................................................
Fix flyover positioning for RTL environments Before this fix the flyover would appear on the wrong side in an RTL languagel. Positioning the flyover itself is easy - just matching the gravity to the <body> directionality. Making the arrow look good was hard, however, and can probably be done with much cleaner CSS. At the time of submission this patch works well on the master branch of AFTv5 and with core fix I5db952bc applied. Change-Id: I0d153c5860e6c364a4f3319531c0b8540e8a6bb2 --- M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Matthias Mullie: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/21827 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d153c5860e6c364a4f3319531c0b8540e8a6bb2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Amire80 <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
