Ori.livneh has submitted this change and it was merged.
Change subject: Disable MobileWebInfobox's attemptLogEvent
......................................................................
Disable MobileWebInfobox's attemptLogEvent
Change-Id: I3efc1fa64ec804aab8410e24d483eeb19463eea3
(cherry picked from commit 925407cd72093509b60a5640c7f0eb8891c628e4)
---
M javascripts/loggingSchemas/MobileWebInfobox.js
1 file changed, 2 insertions(+), 12 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
diff --git a/javascripts/loggingSchemas/MobileWebInfobox.js
b/javascripts/loggingSchemas/MobileWebInfobox.js
index 2e0e1ac..bbb97f9 100644
--- a/javascripts/loggingSchemas/MobileWebInfobox.js
+++ b/javascripts/loggingSchemas/MobileWebInfobox.js
@@ -5,20 +5,10 @@
viewportHeight = $( window ).height(),
scrollingHasCommenced = false,
userScrolledToInfobox = false,
- userScrolledPastInfobox = false,
- recorded = false;
+ userScrolledPastInfobox = false;
function attemptLogEvent() {
- if ( logData['in'] && logData.out && !recorded ) {
- recorded = true;
- clearInterval( interval );
- return M.log( 'MobileWebInfobox', logData );
- } else {
- /* Hijack below expects a deferred object. We should only log
on the first click to MobileWebInfobox
- In the situation where you click a link in the infobox then
click another the always handler should
- still be able to fire so that the link can be navigated to.*/
- return $.Deferred().resolve();
- }
+ return $.Deferred().resolve();
}
function detectInfobox() {
--
To view, visit https://gerrit.wikimedia.org/r/96400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3efc1fa64ec804aab8410e24d483eeb19463eea3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf3
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
