Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96543
Change subject: Update documentation in HTMLCacheUpdateJob
......................................................................
Update documentation in HTMLCacheUpdateJob
Change-Id: I2774d5bd400b9a26415a6a93561c02ea0588e448
---
M includes/job/jobs/HTMLCacheUpdateJob.php
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/43/96543/1
diff --git a/includes/job/jobs/HTMLCacheUpdateJob.php
b/includes/job/jobs/HTMLCacheUpdateJob.php
index 44c240b..be12937 100644
--- a/includes/job/jobs/HTMLCacheUpdateJob.php
+++ b/includes/job/jobs/HTMLCacheUpdateJob.php
@@ -51,9 +51,9 @@
/**
* Construct a job
- * @param $title Title: the title linked to
+ * @param Title $title The title linked to
* @param array $params job parameters (table, start and end page_ids)
- * @param $id Integer: job id
+ * @param int $id Job id
*/
function __construct( $title, $params, $id = 0 ) {
global $wgUpdateRowsPerJob, $wgUpdateRowsPerQuery;
@@ -131,9 +131,8 @@
* using a pre-calculated title array which gives the links in that
range.
* Queue the resulting jobs.
*
- * @param $titleArray array
- * @param $rootJobParams array
- * @return void
+ * @param array $titleArray
+ * @param array $rootJobParams
*/
protected function insertJobsFromTitles( $titleArray, $rootJobParams =
array() ) {
// Carry over any "root job" information
@@ -184,8 +183,7 @@
}
/**
- * @param $rootJobParams array
- * @return void
+ * @param array $rootJobParams
*/
protected function insertPartitionJobs( $rootJobParams = array() ) {
// Carry over any "root job" information
@@ -213,7 +211,7 @@
/**
* Invalidate an array (or iterator) of Title objects, right now
- * @param $titleArray array
+ * @param array $titleArray
*/
protected function invalidateTitles( $titleArray ) {
global $wgUseFileCache, $wgUseSquid;
@@ -223,6 +221,7 @@
# Get all IDs in this query into an array
$ids = array();
+ /** @var Title $title */
foreach ( $titleArray as $title ) {
$ids[] = $title->getArticleID();
}
--
To view, visit https://gerrit.wikimedia.org/r/96543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2774d5bd400b9a26415a6a93561c02ea0588e448
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
