Jhall has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96645


Change subject: [Browser test] Initial stab at test for VE media interface 
(needs more work!)
......................................................................

[Browser test] Initial stab at test for VE media interface (needs more work!)

Change-Id: I3864e04935eca1ae7c9d70df42fd34ce58e90d66
---
A modules/ve-mw/test/browser/features/media_interface.feature
A modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
3 files changed, 37 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/45/96645/1

diff --git a/modules/ve-mw/test/browser/features/media_interface.feature 
b/modules/ve-mw/test/browser/features/media_interface.feature
new file mode 100644
index 0000000..050d54d
--- /dev/null
+++ b/modules/ve-mw/test/browser/features/media_interface.feature
@@ -0,0 +1,18 @@
+@ie6-bug  @ie7-bug  @ie8-bug @ie9-bug @ie10-bug @en.wikipedia.beta.wmflabs.org 
@test2.wikipedia.org @login
+Feature: VisualEditor Media Interface
+
+  Scenario Outline: VisualEditor insert new media
+    Given I am logged in
+      And I am at my user page
+    When I click Edit for VisualEditor
+      And I click Media
+      And I enter <search_term> into media Search box
+      And I select an Image
+      And I click Save page
+      And I click Review your changes
+    Then <expected_markup_text> should appear in the diff view
+      And I can click the X on the save box
+  Examples:
+  | search_term    | expected_markup_text                                      
                               |
+  | San Francisco  | [[File:California county map (San Francisco County 
highlighted).svg\|thumb\|150x150px]]  |
+
diff --git 
a/modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb 
b/modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
new file mode 100644
index 0000000..be3e07d
--- /dev/null
+++ 
b/modules/ve-mw/test/browser/features/step_definitions/media_interface_steps.rb
@@ -0,0 +1,14 @@
+When(/^I click Media$/) do
+  on(VisualEditorPage) do |page|
+    page.more_menu_element.when_present.click
+    page.ve_media_menu_element.when_present.click
+  end
+end
+
+When(/^I enter (.+) into media Search box$/) do |content|
+  on(VisualEditorPage).media_search_element.when_present.send_keys(content)
+end
+
+When(/^I select an Image$/) do
+  on(VisualEditorPage).media_select_element.when_present.click
+end
\ No newline at end of file
diff --git 
a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb 
b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
index e12749c..25c61bb 100644
--- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
@@ -35,8 +35,9 @@
   span(:ve_computer_code, class: 'oo-ui-iconedElement-icon oo-ui-icon-code')
   div(:ve_heading_menu, class: 'oo-ui-iconedElement-icon oo-ui-icon-down')
   span(:ve_link_icon, class: 'oo-ui-iconedElement-icon oo-ui-icon-link')
-  span(:ve_references, class: 'oo-ui-iconedElement-icon oo-ui-icon-reference')
+  span(:ve_media_menu, class: 'oo-ui-iconedElement-icon oo-ui-icon-picture')
   span(:ve_numbering, class: 'oo-ui-iconedElement-icon oo-ui-icon-number-list')
+  span(:ve_references, class: 'oo-ui-iconedElement-icon oo-ui-icon-reference')
   span(:ve_strikethrough, class: 'oo-ui-iconedElement-icon 
oo-ui-icon-strikethrough-s')
   span(:ve_subscript, class: 'oo-ui-iconedElement-icon oo-ui-icon-subscript')
   span(:ve_superscript, class: 'oo-ui-iconedElement-icon 
oo-ui-icon-superscript')
@@ -71,6 +72,9 @@
     span(:apply_changes, text: 'Apply changes', frame: frame)
     div(:content_box, class: 've-ce-documentNode ve-ce-branchNode', frame: 
frame)
     span(:insert_reference, text: 'Insert reference', frame: frame)
+    # span(:media_search, class: 'oo-ui-textInputWidget-icon 
oo-ui-icon-search', frame: frame)
+    text_field(:media_search, placeholder: 'Search for media', frame: frame)
+    div(:media_select, class: 've-ui-mwMediaResultWidget-overlay', frame: 
frame)
     text_field(:parameter_box, index: 0, frame: frame)
     span(:remove_parameter, text: 'Remove parameter', frame: frame)
     span(:remove_template, text: 'Remove template', frame: frame)

-- 
To view, visit https://gerrit.wikimedia.org/r/96645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3864e04935eca1ae7c9d70df42fd34ce58e90d66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jhall <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to