Cscott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96711


Change subject: Node 0.8 compatibility.
......................................................................

Node 0.8 compatibility.

Change-Id: Ia0d4c9b82f71525dd4c9dfb867824a6860d63ded
---
M lib/index.js
M package.json
2 files changed, 9 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection/OfflineContentGenerator/latex_renderer
 refs/changes/11/96711/1

diff --git a/lib/index.js b/lib/index.js
index ddc7040..f4ab5bf 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -16,6 +16,11 @@
 var when = require('when');
 tmp.setGracefulCleanup();
 
+// node 0.8 compatibility
+if (!stream.Writable) {
+       stream = require('readable-stream');
+}
+
 var Db = require('./db');
 
 // my own version of nodefn.call with an explicit 'this', used for methods
@@ -647,12 +652,13 @@
        } else {
                // trivially wrap process.stdout so we don't get an error when
                // pipe() tries to close it (stdout can't be closed w/o 
throwing)
-               writeStream = new stream.Writable();
+               writeStream = new stream.Writable({ decodeStrings: true });
                writeStream._write = function(chunk, encoding, callback) {
-                       return process.stdout.write(chunk, encoding, callback);
+                       return process.stdout.write(chunk, callback);
                };
        }
        writeStream.on('finish', function() { deferred.resolve(); });
+       writeStream.on('close', function() { deferred.resolve(); });
 
        if (options.debug) {
                options.log('Writing LaTeX');
diff --git a/package.json b/package.json
index f1dc976..29e472d 100644
--- a/package.json
+++ b/package.json
@@ -22,6 +22,7 @@
     "easyimage": "~0.1.3",
     "es6-shim": "~0.9.1",
     "gammalatex": 
"git+https://github.com/gammasoft/latex#66a075a82e3b1473404f652ea956a8e4841f3c66";,
+    "readable-stream": "~1.1.9",
     "request": "~2.27.0",
     "sqlite3": "~2.1.19",
     "tmp": "~0.0.21",

-- 
To view, visit https://gerrit.wikimedia.org/r/96711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0d4c9b82f71525dd4c9dfb867824a6860d63ded
Gerrit-PatchSet: 1
Gerrit-Project: 
mediawiki/extensions/Collection/OfflineContentGenerator/latex_renderer
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to