jenkins-bot has submitted this change and it was merged.
Change subject: Bug 54868 - isDisambig results in AttributeError
......................................................................
Bug 54868 - isDisambig results in AttributeError
Set _pageprops to {} per default before updating from live site as
- a page without any pageprops has no corresponding entry in the pagedict and,
thus, Page._pageprops will not be set in api.update_page()
- the pageprops may be removed after a forced update
Same problem (ValueError in Page) for Page.coordinates() if the page has no
coordinates fixed in Page.
Change-Id: I557733ab88d43b4577678dfc0c36ae383bc7dce5
---
M pywikibot/page.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index eefc5d9..c0aa834 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -377,6 +377,7 @@
@return: dict
"""
if not hasattr(self, '_pageprops') or force:
+ self._pageprops = {} # page may not have pageprops (see bug 54868)
self.site.loadpageprops(self)
return self._pageprops
@@ -1143,9 +1144,10 @@
@return: A list of Coordinate objects
"""
if not hasattr(self, '_coords'):
+ self._coords = []
self.site.loadcoordinfo(self)
if primary_only:
- return self._coords[0]
+ return self._coords[0] if len(self._coords) > 0 else None
else:
return self._coords
--
To view, visit https://gerrit.wikimedia.org/r/87060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I557733ab88d43b4577678dfc0c36ae383bc7dce5
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: FelixReimann <[email protected]>
Gerrit-Reviewer: FelixReimann <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Mpaa <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
