Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/97306


Change subject: Xml::textarea: Custom attributes should override default ones
......................................................................

Xml::textarea: Custom attributes should override default ones

Use-case (and follow-up to): I7ef63488.

Change-Id: I44f33522cae22aa94803cc43973c3b6ba9c73696
---
M includes/Xml.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/06/97306/1

diff --git a/includes/Xml.php b/includes/Xml.php
index ac0539d..c1615fc 100644
--- a/includes/Xml.php
+++ b/includes/Xml.php
@@ -588,12 +588,12 @@
         */
        public static function textarea( $name, $content, $cols = 40, $rows = 
5, $attribs = array() ) {
                return self::element( 'textarea',
-                                       array(
+                                       $attribs + array(
                                                'name' => $name,
                                                'id' => $name,
                                                'cols' => $cols,
                                                'rows' => $rows
-                                       ) + $attribs,
+                                       ),
                                        $content, false );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/97306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44f33522cae22aa94803cc43973c3b6ba9c73696
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to