Platonides has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/97337


Change subject: LanguageGvTest::testGetPluralRuleType() has never worked
......................................................................

LanguageGvTest::testGetPluralRuleType() has never worked

(added in January, 06b0967caa524e8f50e26aa8a9c6e1650f28c1db)

Comment it and remove that innecessary bloat from phpunit output.

Change-Id: I7a07a049583bb7874877dafb4484d66ef1b8996b
---
M tests/phpunit/languages/LanguageGvTest.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/37/97337/1

diff --git a/tests/phpunit/languages/LanguageGvTest.php 
b/tests/phpunit/languages/LanguageGvTest.php
index a0def62..9728f9b 100644
--- a/tests/phpunit/languages/LanguageGvTest.php
+++ b/tests/phpunit/languages/LanguageGvTest.php
@@ -21,11 +21,12 @@
        /**
         * @dataProvider providePlural
         * @covers Language::getPluralRuleType
-        */
+        *
        public function testGetPluralRuleType( $result, $value ) {
                $this->markTestSkipped( "This test won't work since 
convertPlural for gv doesn't seem to actually follow our plural rules." );
                $this->assertEquals( $result, 
$this->getLang()->getPluralRuleType( $value ) );
        }
+       */
 
        public static function providePlural() {
                return array(

-- 
To view, visit https://gerrit.wikimedia.org/r/97337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a07a049583bb7874877dafb4484d66ef1b8996b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to