jenkins-bot has submitted this change and it was merged.
Change subject: Some fixes to the new overlay
......................................................................
Some fixes to the new overlay
1. Making continue and save buttons line up with the rest of the
header by giving them a -1px bottom-margin.
2. Making continue button flip in RTL languages
(Bug: 57404)
3. Fixing background position of .overlay .license so that the
graphic isn't clipped at the bottom. (18px - 16px is 2px, not 4px).
Change-Id: I97027b065e80b6057f4a0a879e2a6481c916ad84
---
M less/common/OverlayNew.less
A less/common/images/continue-ltr.png
A less/common/images/continue-rtl.png
3 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/less/common/OverlayNew.less b/less/common/OverlayNew.less
index 03f1b1e..19b85da 100644
--- a/less/common/OverlayNew.less
+++ b/less/common/OverlayNew.less
@@ -92,6 +92,8 @@
button {
margin-top: -@overlayHeaderMargin;
+ // Line up with rest of header that has 1px
bottom-border
+ margin-bottom: -1px;
}
> ul:first-child li:first-child button {
@@ -127,7 +129,7 @@
}
&.continue {
- background-image: url(images/continue.png);
+ background-image: url(images/continue-ltr.png);
background-color: #2f81f0;
}
@@ -143,8 +145,8 @@
}
.license {
- // FIXME: move this image?
- background: url('../modules/images/cc-by-sa.png') left 4px
no-repeat;
+ // FIXME: image should not be hard-coded
+ background: url('../modules/images/cc-by-sa.png') left 2px
no-repeat;
.background-size( auto, 16px );
padding-left: 55px;
font-size: .9em;
diff --git a/less/common/images/continue-ltr.png
b/less/common/images/continue-ltr.png
new file mode 100644
index 0000000..c8cb5ed
--- /dev/null
+++ b/less/common/images/continue-ltr.png
Binary files differ
diff --git a/less/common/images/continue-rtl.png
b/less/common/images/continue-rtl.png
new file mode 100644
index 0000000..f69f99e
--- /dev/null
+++ b/less/common/images/continue-rtl.png
Binary files differ
--
To view, visit https://gerrit.wikimedia.org/r/97213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97027b065e80b6057f4a0a879e2a6481c916ad84
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
