jenkins-bot has submitted this change and it was merged.
Change subject: (bug 57532) Topics started by an IP show as "Topic started by
[current user's IP]"
......................................................................
(bug 57532) Topics started by an IP show as "Topic started by [current user's
IP]"
No strict comparison against id
User id may be string '0', in which case User::newFromId( '0' ) will be the
creator. getName() will then default to request IP, instead of creator IP
Bug: 57532
Change-Id: I9f989a39ca318e618f5527b353967e0309b3d6fa
---
M includes/Model/PostRevision.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bsitu: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Model/PostRevision.php b/includes/Model/PostRevision.php
index 63585eb..dace913 100644
--- a/includes/Model/PostRevision.php
+++ b/includes/Model/PostRevision.php
@@ -135,7 +135,7 @@
*/
public function getCreator( $user = null ) {
if ( $this->isAllowed( $user ) ) {
- if ( $this->getCreatorIdRaw() !== 0 ) {
+ if ( $this->getCreatorIdRaw() != 0 ) {
$user = User::newFromId(
$this->getCreatorIdRaw() );
} else {
// Don't validate username; (anon) IP user
object is fine.
--
To view, visit https://gerrit.wikimedia.org/r/97494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f989a39ca318e618f5527b353967e0309b3d6fa
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: OliverKeyes <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
