jenkins-bot has submitted this change and it was merged.
Change subject: Set visibility on class properties of Job
......................................................................
Set visibility on class properties of Job
Change-Id: Ib8c85e8b1ca46855dfdb1678639d1d1b749d87a3
---
M includes/job/Job.php
1 file changed, 17 insertions(+), 10 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/job/Job.php b/includes/job/Job.php
index 0359540..b1400de 100644
--- a/includes/job/Job.php
+++ b/includes/job/Job.php
@@ -28,20 +28,27 @@
* @ingroup JobQueue
*/
abstract class Job {
- /**
- * @var Title
- */
- var $title;
+ /** @var int Job identifier */
+ public $id;
- var $command,
- $params,
- $id,
- $removeDuplicates,
- $error;
+ /** @var string */
+ public $command;
- /** @var Array Additional queue metadata */
+ /** @var array|bool Array of job parameters or false if none */
+ public $params;
+
+ /** @var array Additional queue metadata */
public $metadata = array();
+ /** @var Title */
+ protected $title;
+
+ /** @var bool Expensive jobs may set this to true */
+ protected $removeDuplicates;
+
+ /** @var string Text for error that occurred last */
+ protected $error;
+
/*-------------------------------------------------------------------------
* Abstract functions
*------------------------------------------------------------------------*/
--
To view, visit https://gerrit.wikimedia.org/r/97519
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8c85e8b1ca46855dfdb1678639d1d1b749d87a3
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
