Subramanya Sastry has uploaded a new change for review. https://gerrit.wikimedia.org/r/97561
Change subject: Fixed improper application of changetrees to simulate edits. ...................................................................... Fixed improper application of changetrees to simulate edits. * The change-tree application code had a glaring bug where changes wouldn't be made to a node if it was not an element node. This was a leftover from earlier versions of the code which wasn't removed during updates to the edit simulation code. So, a lot of change trees with "2/3/4" set on comment/text nodes were never being applied so far which effectively stunted our selser testing strategy by reducing the # of unique randomized tests. * Regenerated blacklist (unsurprisingly, more selser tests are now failing). * Also updated debug output for the 'dump:changetree' to emit DOM before/after changetree application (which is what highlighted the bug by showing far fewer changes on the DOM than what the changetree indicated). Change-Id: I73ed5aa55191e3465e229ccf4dc345ec6189abd0 --- M js/tests/parserTests-blacklist.js M js/tests/parserTests.js 2 files changed, 984 insertions(+), 1,092 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/61/97561/1 -- To view, visit https://gerrit.wikimedia.org/r/97561 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73ed5aa55191e3465e229ccf4dc345ec6189abd0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
