MaxSem has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/97704


Change subject: Fix fatal in ParserCache::getKey()
......................................................................

Fix fatal in ParserCache::getKey()

Bug: 57370
Change-Id: I0b7d8d5e82f642b07f908dc2681dfe8b109e0ecc
---
M includes/parser/ParserCache.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/04/97704/1

diff --git a/includes/parser/ParserCache.php b/includes/parser/ParserCache.php
index 7043b4a..8a0d12d 100644
--- a/includes/parser/ParserCache.php
+++ b/includes/parser/ParserCache.php
@@ -135,7 +135,7 @@
 
                // Determine the options which affect this article
                $optionsKey = $this->mMemc->get( $this->getOptionsKey( $article 
) );
-               if ( $optionsKey != false ) {
+               if ( $optionsKey instanceof CacheTime ) {
                        if ( !$useOutdated && $optionsKey->expired( 
$article->getTouched() ) ) {
                                wfIncrStats( "pcache_miss_expired" );
                                $cacheTime = $optionsKey->getCacheTime();

-- 
To view, visit https://gerrit.wikimedia.org/r/97704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b7d8d5e82f642b07f908dc2681dfe8b109e0ecc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to