jenkins-bot has submitted this change and it was merged.
Change subject: Removed check for global that was removed from core
......................................................................
Removed check for global that was removed from core
Change-Id: I85d00ecaf991baf558e4904616a4b85315f6110e
---
M GlobalUsageHooks.php
1 file changed, 9 insertions(+), 17 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GlobalUsageHooks.php b/GlobalUsageHooks.php
index c279788..8411181 100644
--- a/GlobalUsageHooks.php
+++ b/GlobalUsageHooks.php
@@ -34,26 +34,18 @@
$missingFiles = array_diff( $images, $localFiles );
- global $wgUseDumbLinkUpdate;
$gu = self::getGlobalUsage();
- if ( $wgUseDumbLinkUpdate ) {
- // Delete all entries to the page
- $gu->deleteLinksFromPage( $title->getArticleID(
Title::GAID_FOR_UPDATE ) );
- // Re-insert new usage for the page
- $gu->insertLinks( $title, $missingFiles );
- } else {
- $articleId = $title->getArticleID(
Title::GAID_FOR_UPDATE );
- $existing = $gu->getLinksFromPage( $articleId );
+ $articleId = $title->getArticleID( Title::GAID_FOR_UPDATE );
+ $existing = $gu->getLinksFromPage( $articleId );
- // Calculate changes
- $added = array_diff( $missingFiles, $existing );
- $removed = array_diff( $existing, $missingFiles );
+ // Calculate changes
+ $added = array_diff( $missingFiles, $existing );
+ $removed = array_diff( $existing, $missingFiles );
- // Add new usages and delete removed
- $gu->insertLinks( $title, $added );
- if ( $removed ) {
- $gu->deleteLinksFromPage( $articleId, $removed
);
- }
+ // Add new usages and delete removed
+ $gu->insertLinks( $title, $added );
+ if ( $removed ) {
+ $gu->deleteLinksFromPage( $articleId, $removed );
}
return true;
--
To view, visit https://gerrit.wikimedia.org/r/97660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85d00ecaf991baf558e4904616a4b85315f6110e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalUsage
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
