jenkins-bot has submitted this change and it was merged.
Change subject: Also apply autonumbering CSS to links in generated content
......................................................................
Also apply autonumbering CSS to links in generated content
We had CSS that applied to our rendering of autonumbered links,
but not for raw <a rel="mw:ExtLink"></a> tags appearing in
generated content like templates.
Bug: 57420
Change-Id: Ic1585ecb1a133d16b7393ce0ce38a11b76cc2239
---
M modules/ve-mw/ce/nodes/ve.ce.MWNumberedExternalLinkNode.js
M modules/ve-mw/ce/styles/ve.ce.Node.css
2 files changed, 9 insertions(+), 5 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
GWicke: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWNumberedExternalLinkNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWNumberedExternalLinkNode.js
index d87b8d3..0723ecd 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWNumberedExternalLinkNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWNumberedExternalLinkNode.js
@@ -23,12 +23,16 @@
ve.ce.FocusableNode.call( this );
// DOM changes
- this.$element.addClass( 've-ce-mwNumberedExternalLinkNode' );
- // Need CE=false to prevent selection issues
- this.$element.prop( 'contentEditable', 'false' );
+ this.$element
+ .addClass( 've-ce-mwNumberedExternalLinkNode' )
+ // Need CE=false to prevent selection issues
+ .prop( 'contentEditable', 'false' );
// Add link
- this.$link = this.$( '<a>' ).appendTo( this.$element );
+ this.$link = this.$( '<a>' )
+ // CSS for numbering needs rel=mw:ExtLink
+ .attr( 'rel', 'mw:ExtLink' )
+ .appendTo( this.$element );
// Events
this.model.connect( this, { 'update': 'onUpdate' } );
diff --git a/modules/ve-mw/ce/styles/ve.ce.Node.css
b/modules/ve-mw/ce/styles/ve.ce.Node.css
index d907fe9..b96ee44 100644
--- a/modules/ve-mw/ce/styles/ve.ce.Node.css
+++ b/modules/ve-mw/ce/styles/ve.ce.Node.css
@@ -75,7 +75,7 @@
counter-reset: ve-ce-mwNumberedExternalLinkNode;
}
-.ve-ce-mwNumberedExternalLinkNode a:empty:after {
+a[rel~="mw:ExtLink"]:empty:after {
content: "[" counter(ve-ce-mwNumberedExternalLinkNode) "]";
counter-increment: ve-ce-mwNumberedExternalLinkNode;
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/97037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1585ecb1a133d16b7393ce0ce38a11b76cc2239
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
